hub.darcs.net :: ross -> transformers -> issue

#91Migrate Foldable1 instances

Ryan Scott

The Foldable1 class (originally from the semigroupoids library) was added to base in version 4.18.0.0 (GHC 9.6.1). The semigroupoids library defined Foldable1 instances for data types from transformers, so we should migrate those instances to transformers itself.

I've implemented this change in https://hub.darcs.net/RyanGlScott/transformers/patch/6e6f1a275a957ec1acb5a7785e18a22306c86a1e on my transformers fork.

• Ross PatersonWed Feb 1 15:05:20 UTC 2023
  • status set to closed

  applied, thanks

• Ryan ScottThu Feb 2 13:03:14 UTC 2023

  Thanks! Would you be able to make a new Hackage release containing these changes? (Ideally, we could update GHC to use this version of transformers before a final version of GHC 9.6.1 is released.)

• Ross PatersonThu Feb 2 13:23:11 UTC 2023

  Possible. I think this will require a major version increment, so there are a couple of other things I'd like to change at the same time.

• Ryan ScottThu Feb 2 14:09:46 UTC 2023

  Major in the sense of incrementing from 0.6 to 0.7? I was under the impression that the PVP does not require a major version bump if the only thing that you are adding are instances. (See the "Non-breaking changes" section under https://pvp.haskell.org/#version-numbers)

• Ross PatersonThu Feb 2 14:56:59 UTC 2023

  I think you're right, provided semigroupoids < 5.4 has its dependency tightened on hackage to base < 4.18 (which needs to happen anyway).

• Ryan ScottThu Feb 2 15:17:55 UTC 2023

  Yes, good point. I've applied appropriate revisions to all current semigroupoids Hackage releases to ensure that they are not buildable with base-4.18/GHC 9.6.

• Ross PatersonSat Feb 4 08:26:28 UTC 2023

  I've uploaded it as 0.6.1.0.

• Ryan ScottSat Feb 4 12:43:21 UTC 2023

  Thanks again!