hub.darcs.net :: simon -> darcsden -> issue

#143embedded svg images don't display

Simon Michael

The svgs aren't showing at http://hub.darcs.net/pointfree/darcs-swag for some reason.

• Andreas WagnerTue Dec 1 05:39:57 UTC 2015

  I found that when I change (\(OK _) -> serveFileAs "text/plain" $ repoDir (view rOwner r) (view rName r) </> f) to (\(OK _) -> serveFile $ repoDir (view rOwner r) (view rName r) </> f) in getBrowseRawFileR the SVGs display as images in the README.md just fine because then darcsden is not trying to display them as text files (when I embed the image I link to the /raw-file url). So then, naturally /raw-file PDFs display as PDFs, not as text files.

  However, that's not really a solution yet in IMHO because when we want to view a .md file as /raw-file we don't necessarily want to download it which is what would happen when we go for the latter method.

  One solution for display text files as text and binary files as their own filetype is to detect the character encoding of the file. If Nothing is detected, assume it is binary, if a character encoding is detected assume it is text/plain.

  https://github.com/aelve/charsetdetect-ae/blob/master/example/Main.hs

  Thoughts?

• Andreas WagnerTue Dec 1 19:58:15 UTC 2015

  Hm, maybe http://hackage.haskell.org/package/magic-1.1 is more the thing for this. I will have to try it out.

• Andreas WagnerTue Dec 15 20:30:59 UTC 2015

  The following patch will render binary files under raw-file/ if they are recognized by the browser and download them otherwise. As I think about it, I think more and more this is a good behavior (we view files as text/plain under browse/ ...right?) So, PDFs will be displayed as PDFs and SVGs will be displayed as SVGs under `raw-file/'

  http://hub.darcs.net/pointfree/darcsden-ui/patch/445b4b8f496df2b3b3dc9a77041e938ab9b607c3

  This fixes this issue because I was using raw-file/ paths to display the SVG images.

  It would be nice to display unrecognized formats as text/plain if they are identified as plain text by magic (uses the same system as the unix file command). We may want to view the raw markdown of a .md file...

• Andreas WagnerWed Dec 23 05:58:28 UTC 2015

  I have new patches to solve this problem in a more satisfactory way.

  Displays raw-file/ as text/plain if MIME type begins with text/

  Markdown files will be rendered as markdown under browse/ and viewed as text/plain under raw-file/ SVGs will be rendered when embedded or viewed as raw-file/ and viewed as code under browse/

  http://hub.darcs.net/pointfree/darcsden-ui/patch/f1df518f487b405acca4a0b8fe1933131c0c8981

  Also added application/pdf MIME type:

  http://hub.darcs.net/pointfree/darcsden-ui/patch/a6c0300b902cf0e87e5638e4f1bdade7067999cd

• Andreas WagnerMon Nov 21 19:26:17 UTC 2016

  @simon, is this now WONTFIX?

• Simon MichaelMon Nov 21 19:55:14 UTC 2016

  No! Thanks for the bump. I am working on a new build now.

• Simon MichaelMon Nov 21 21:32:13 UTC 2016

  @pointfree, I have merged and deployed this, and see images at http://hub.darcs.net/pointfree/darcs-swag/browse/README.md (after shift-reloading), so I think it's working. Thanks!

  (Unrelated: darcs hub's last darcsden build was in january, so we should now also have your username linkification in issues patch, but I don't see it working.)

• Andreas WagnerTue Jan 3 14:00:42 UTC 2017
  • status set to closed

  This works now.