hub.darcs.net :: simon -> darcsden -> issue

#3browsing binary files, eg images, gives an error

Simon Michael

Eg: http://hub.darcs.net/simon/darcsden/browse/public/images/added.gif

Currently highlighter is run on the content of all files but it expects utf-8-encoded data, at least in the way that it is called here.

http://hub.darcs.net/simon/darcsden/browse/src/DarcsDen/Handler/Repository.hs#L-154

http://hub.darcs.net/simon/darcsden/browse/src/DarcsDen/Handler/Repository/Util.hs#L-35

http://hackage.haskell.org/packages/archive/highlighter/0.2.2/doc/html/src/Text-Highlighter-Formatters-Html.html#format

• Simon MichaelMon Aug 13 15:54:51 UTC 2012
  • description updated
• Simon MichaelMon Aug 13 15:55:06 UTC 2012
  • description updated
• Simon MichaelMon Aug 13 16:00:20 UTC 2012

  This attempted fix in browseRepo fails to catch the exception:

      (_, Just source) -> do
          highlighted <- liftIO $
                         (return $ highlightBlob (last f) (strictLBS source))
                         `E.catch`
                         (\(_ :: SomeException) -> return $ BS8.pack $
                           ("Could not highlight, here is the <a href=\"raw/"++last f++"\">raw file content</a>"))

• Simon MichaelMon Aug 13 18:47:20 UTC 2012
  • status set to closed

  Due to laziness. Fixed now.