hub.darcs.net :: ownwaterloo -> darcsweb -> changes

This patch makes darcsweb use subprocess.Popen() for running darcs, instead of os.popen4() which has been deprecated.

The bulk of the change is actually a modification of run_darcs()' API, because it now takes the parameters as a list of strings, instead of just a big string as it was before, which is cleaner and safer.

Recent versions of darcs require the $PATH environment variable to be set, in order to find "diff". Some http servers don't set it, and darcs will fail to diff.

This patch attempts to set a basic path variable hoping that it will work for most cases; it is really up to the server to set it if diff is not in one of these places.

We should use hashlib when available (Python >= 2.5); we continue to fall back to the old sha library if it's not.

Thanks to Karl O. Pinc for the bug report.

This patch makes darcsweb ignore comments in the author file.

Prevents `Copying pristine' messages in output with darcs pre-2.5.

String exceptions are deprecated and will soon no longer be supported at all.

Most of the instances of string exceptions in our code were not meant to be catched, but just to get meaningful backtraces.

This patch replaces them with appropriate, usually generic, exceptions that serve the same purpose.

With this, darcsweb can list the full darcs repo log.

Otherwise, we pay for the pygments import (which is noticeable) on every darcsweb page view.

This follows the lazy module loading that is already being done for other costly modules (i.e. 're').

When a multidir directory is not really a directory or a valid symlink to one, we want to skip it instead of exploding.

This patch fixes that by doing a simple sanity check while processing the configured multidirs.

Thanks to Ralph Giles giles@ghostscript.com for the report and the patch.

Very old darcs commits use a different time format, that leaks out in some operations like annotate. This patch makes darcsweb able to handle it.

Thanks to Simon Michael simon@joyful.com for the report and the help.

A very simple change, makes the code more straightforward.

darcs 2 doesn't like files beginning with / as parameters for annotate. Since darcs 1 doesn't care, remove the '/' before running darcs.

In darcs 2, there is no _darcs/inventory, so use the patches directory to find out the last modification time of the repository.

Thanks to Patrick Waugh (ptwaugh@gmail.com) for providing (and testing) this fix.